Pajaraja commented on code in PR #51847:
URL: https://github.com/apache/spark/pull/51847#discussion_r2318663849


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InlineCTE.scala:
##########
@@ -189,14 +189,30 @@ case class InlineCTE(
 
       case ref: CTERelationRef =>
         val refInfo = cteMap(ref.cteId)
+        val cteBody = refInfo.cteDef.child match {

Review Comment:
   I think it is okay to only propagate the Limit All into the CTERelationRef 
inside its subtree. This is how it works for other values of LIMIT.
   
   This is also how the current implementation works since it binds to a 
CTERelationRef.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to