srielau commented on code in PR #52173:
URL: https://github.com/apache/spark/pull/52173#discussion_r2319090080
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisErrorSuite.scala:
##########
@@ -834,79 +834,14 @@ class AnalysisErrorSuite extends AnalysisTest with
DataTypeErrorsBase {
""""explode(array(min(a)))", "explode(array(max(a)))"""" :: Nil
)
- errorConditionTest(
- "EXEC IMMEDIATE - nested execute immediate not allowed",
- CatalystSqlParser.parsePlan("EXECUTE IMMEDIATE 'EXECUTE IMMEDIATE
\\\'SELECT 42\\\''"),
- "NESTED_EXECUTE_IMMEDIATE",
- Map(
- "sqlString" -> "EXECUTE IMMEDIATE 'SELECT 42'"))
-
- errorConditionTest(
- "EXEC IMMEDIATE - both positional and named used",
- CatalystSqlParser.parsePlan("EXECUTE IMMEDIATE 'SELECT 42 where ? =
:first'" +
- " USING 1, 2 as first"),
- "INVALID_QUERY_MIXED_QUERY_PARAMETERS",
- Map.empty)
-
- test("EXEC IMMEDIATE - non string variable as sqlString parameter") {
- val execImmediatePlan = ExecuteImmediateQuery(
- Seq.empty,
- scala.util.Right(UnresolvedAttribute("testVarA")),
- Seq(UnresolvedAttribute("testVarA")))
-
- assertAnalysisErrorCondition(
- inputPlan = execImmediatePlan,
- expectedErrorCondition =
"INVALID_VARIABLE_TYPE_FOR_QUERY_EXECUTE_IMMEDIATE",
- expectedMessageParameters = Map(
- "varType" -> "\"INT\""
- ))
- }
- test("EXEC IMMEDIATE - Null string as sqlString parameter") {
- val execImmediatePlan = ExecuteImmediateQuery(
- Seq.empty,
- scala.util.Right(UnresolvedAttribute("testVarNull")),
- Seq(UnresolvedAttribute("testVarNull")))
- assertAnalysisErrorCondition(
- inputPlan = execImmediatePlan,
- expectedErrorCondition = "NULL_QUERY_STRING_EXECUTE_IMMEDIATE",
- expectedMessageParameters = Map("varName" -> "`testVarNull`"))
- }
Review Comment:
They are moved. Mainly because they are not returning AnalysisError any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
