viirya commented on code in PR #52216: URL: https://github.com/apache/spark/pull/52216#discussion_r2319319434
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala: ########## @@ -285,8 +293,7 @@ case class GetArrayItem( with ExtractValue with SupportQueryContext { - // We have done type checking for child in `ExtractValue`, so only need to check the `ordinal`. Review Comment: This comment also didn't look correct. Actually we did checking the datatype of the child in `checkInputDataTypes`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org