caldempsey commented on code in PR #152:
URL: https://github.com/apache/spark-connect-go/pull/152#discussion_r2319806880
##########
spark/client/base/base.go:
##########
@@ -48,5 +48,6 @@ type SparkConnectClient interface {
type ExecuteResponseStream interface {
ToTable() (*types.StructType, arrow.Table, error)
+ ToRecordBatches(ctx context.Context) (<-chan arrow.Record, <-chan
error, *types.StructType)
Review Comment:
Updated to use Seq2
##########
spark/client/base/base.go:
##########
@@ -48,5 +48,6 @@ type SparkConnectClient interface {
type ExecuteResponseStream interface {
ToTable() (*types.StructType, arrow.Table, error)
+ ToRecordBatches(ctx context.Context) (<-chan arrow.Record, <-chan
error, *types.StructType)
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
