Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6551#discussion_r31887692
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
---
@@ -59,6 +59,32 @@ object HiveTypeCoercion {
}
/**
+ * Implicit promote the AtomicType to StringType if
+ * one of the data type in (dt1, dt2) is StringType, and the other is
not either
+ * BooleanType or BinaryType, the TightestCommonType should be StringType
+ * eg: 1. CaseWhenLike case when ... then dt1 else dt2 end
+ * 2. Coalesce(null, dt1, dt2)
+ */
+ private def promoteToStringType(t1: DataType, t2: DataType):
Option[DataType] = (t1, t2) match {
--- End diff --
Here we don't care about the parameter names(i.e. `t1` and `t2`). Using
functions, we can just write the partially applied function(i.e. `{case ...}`)
and don't need to add `(t1, t2) match` before it.
However, it's not a big deal, using method is OK, but we should make it
consistent with existing code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
