cloud-fan commented on code in PR #50230: URL: https://github.com/apache/spark/pull/50230#discussion_r2320766169
########## core/src/main/java/org/apache/spark/shuffle/checksum/RowBasedChecksum.scala: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.shuffle.checksum + +import scala.util.control.NonFatal + +import org.apache.spark.internal.Logging + +/** + * A class for computing checksum for input (key, value) pairs. The checksum is independent of + * the order of the input (key, value) pairs. It is done by computing a checksum for each row + * first, and then computing the XOR for all the row checksums. + */ +abstract class RowBasedChecksum() extends Serializable with Logging { + private val ROTATE_POSITIONS = 27 + private var hasError: Boolean = false + private var checksumXor: Long = 0 + private var checksumSum: Long = 0 + + /** Returns the checksum value. It returns the default checksum value (0) if there + * are any errors encountered during the checksum computation. + */ + def getValue: Long = { + if (!hasError) { + val res = checksumXor ^ rotateLeft(checksumSum) + res + } else { + 0 + } + } + + /** Updates the row-based checksum with the given (key, value) pair */ + def update(key: Any, value: Any): Unit = { Review Comment: is it thread-safe? if now, can we add a comment to mention it? ########## core/src/main/java/org/apache/spark/shuffle/checksum/RowBasedChecksum.scala: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.shuffle.checksum + +import scala.util.control.NonFatal + +import org.apache.spark.internal.Logging + +/** + * A class for computing checksum for input (key, value) pairs. The checksum is independent of + * the order of the input (key, value) pairs. It is done by computing a checksum for each row + * first, and then computing the XOR for all the row checksums. + */ +abstract class RowBasedChecksum() extends Serializable with Logging { + private val ROTATE_POSITIONS = 27 + private var hasError: Boolean = false + private var checksumXor: Long = 0 + private var checksumSum: Long = 0 + + /** Returns the checksum value. It returns the default checksum value (0) if there + * are any errors encountered during the checksum computation. + */ + def getValue: Long = { + if (!hasError) { + val res = checksumXor ^ rotateLeft(checksumSum) + res + } else { + 0 + } + } + + /** Updates the row-based checksum with the given (key, value) pair */ + def update(key: Any, value: Any): Unit = { Review Comment: is it thread-safe? if not, can we add a comment to mention it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
