cloud-fan commented on code in PR #52188:
URL: https://github.com/apache/spark/pull/52188#discussion_r2321483211
##########
sql/connect/common/src/main/scala/org/apache/spark/sql/connect/common/LiteralValueProtoConverter.scala:
##########
@@ -434,11 +434,16 @@ object LiteralValueProtoConverter {
case proto.DataType.KindCase.BOOLEAN => v => v.getBoolean
case proto.DataType.KindCase.STRING => v => v.getString
case proto.DataType.KindCase.BINARY => v => v.getBinary.toByteArray
- case proto.DataType.KindCase.DATE => v => v.getDate
- case proto.DataType.KindCase.TIMESTAMP => v => v.getTimestamp
- case proto.DataType.KindCase.TIMESTAMP_NTZ => v => v.getTimestampNtz
- case proto.DataType.KindCase.DAY_TIME_INTERVAL => v =>
v.getDayTimeInterval
- case proto.DataType.KindCase.YEAR_MONTH_INTERVAL => v =>
v.getYearMonthInterval
+ case proto.DataType.KindCase.DATE =>
+ v => SparkDateTimeUtils.toJavaDate(v.getDate)
Review Comment:
what's the contract here? If we need to get catalyst value at the end, then
converting to Java date is a waste here as we need to convert to int again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
