vrozov commented on code in PR #52237: URL: https://github.com/apache/spark/pull/52237#discussion_r2322812148
########## sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQueryStatusAndProgressSuite.scala: ########## @@ -400,6 +400,35 @@ class StreamingQueryStatusAndProgressSuite extends StreamTest with Eventually { assert(data(0).getAs[Timestamp](0).equals(validValue)) } + test("SPARK-53491: `inputRowsPerSecond` and `processedRowsPerSecond` " + Review Comment: nit: what is the reason to use "`"? ########## sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQueryStatusAndProgressSuite.scala: ########## @@ -400,6 +400,35 @@ class StreamingQueryStatusAndProgressSuite extends StreamTest with Eventually { assert(data(0).getAs[Timestamp](0).equals(validValue)) } + test("SPARK-53491: `inputRowsPerSecond` and `processedRowsPerSecond` " + + "should never be with scientific notation") { + import testImplicits._ + + val inputData = MemoryStream[Int] + val df = inputData.toDF() + val query = df.writeStream + .format("memory") + .queryName("TestFormatting") + .start() + + try { + val bigBatch = 1 to 900000 + inputData.addData(bigBatch: _*) + + query.processAllAvailable() + + val progress = query.lastProgress.jsonValue + + print(progress) + + assert(!(progress \ "inputRowsPerSecond").values.toString.contains("E")) Review Comment: nit: will it be better to use matchers instead of `assert`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org