ivoson commented on code in PR #50230:
URL: https://github.com/apache/spark/pull/50230#discussion_r2322479786
##########
core/src/main/scala/org/apache/spark/Dependency.scala:
##########
@@ -83,9 +88,30 @@ class ShuffleDependency[K: ClassTag, V: ClassTag, C:
ClassTag](
val keyOrdering: Option[Ordering[K]] = None,
val aggregator: Option[Aggregator[K, V, C]] = None,
val mapSideCombine: Boolean = false,
- val shuffleWriterProcessor: ShuffleWriteProcessor = new
ShuffleWriteProcessor)
+ val shuffleWriterProcessor: ShuffleWriteProcessor = new
ShuffleWriteProcessor,
+ val rowBasedChecksums: Array[RowBasedChecksum] =
ShuffleDependency.EMPTY_ROW_BASED_CHECKSUMS)
extends Dependency[Product2[K, V]] with Logging {
+ def this(
+ rdd: RDD[_ <: Product2[K, V]],
+ partitioner: Partitioner,
+ serializer: Serializer,
+ keyOrdering: Option[Ordering[K]],
+ aggregator: Option[Aggregator[K, V, C]],
+ mapSideCombine: Boolean,
+ shuffleWriterProcessor: ShuffleWriteProcessor) = {
+ this(
+ rdd,
+ partitioner,
+ serializer,
+ keyOrdering,
+ aggregator,
+ mapSideCombine,
+ shuffleWriterProcessor,
+ Array.empty
Review Comment:
done
##########
core/src/main/scala/org/apache/spark/MapOutputTracker.scala:
##########
@@ -169,6 +174,15 @@ private class ShuffleStatus(
} else {
mapIdToMapIndex.remove(currentMapStatus.mapId)
}
+ logDebug(s"Checksum of map output for task ${status.mapId} is
${status.checksumValue}")
+
+ val preStatus =
+ if (mapStatuses(mapIndex) != null) mapStatuses(mapIndex) else
mapStatusesDeleted(mapIndex)
+ if (preStatus != null && preStatus.checksumValue != status.checksumValue) {
+ logInfo(s"Checksum of map output changes from ${preStatus.checksumValue}
to " +
+ s"${status.checksumValue} for task ${status.mapId}.")
Review Comment:
yes, it is task id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
