peter-toth commented on PR #52183: URL: https://github.com/apache/spark/pull/52183#issuecomment-3257587826
This PR is very similar to what you have done in https://github.com/apache/spark-kubernetes-operator/pull/298 so I think it would make sense to split the formating logic to smaller parts like `formatGauge()`, `formatHistogram()`... But my biggest concern is that https://github.com/apache/spark-kubernetes-operator/pull/298 was a completely new feature, but here you change an already existing output format. Should't we offer config to keep the old format as well? cc @dongjoon-hyun as you seem to have worked a lot on this `PrometheusServlet`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
