cloud-fan commented on code in PR #50230: URL: https://github.com/apache/spark/pull/50230#discussion_r2324194403
########## core/src/main/scala/org/apache/spark/internal/config/package.scala: ########## @@ -1650,6 +1650,21 @@ package object config { s"The buffer size must be greater than 0 and less than or equal to ${Int.MaxValue}.") .createWithDefault(4096) + private[spark] val SHUFFLE_ORDER_INDEPENDENT_CHECKSUM_ENABLED = Review Comment: This config is only accessed in `ShuffleExchangeExec`, so it makes more sense to be a sql conf. +1 to rename the conf with `spark.sql.` prefix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org