Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6699#discussion_r31893101
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Catalog.scala
---
@@ -81,7 +84,7 @@ trait Catalog {
}
class SimpleCatalog(val conf: CatalystConf) extends Catalog {
- val tables = new mutable.HashMap[String, LogicalPlan]()
+ val tables = new ConcurrentHashMap[String, LogicalPlan] asScala
--- End diff --
Actually it's a bad idea to put a scala wrapper around java's
ConcurrentHashMap. Do you mind just removing the wrapper, and change the call
site to just use the functions defined in ConcurrentHashMap?
Also would be great to mark tables as a private val.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
