mkaravel commented on code in PR #51298:
URL: https://github.com/apache/spark/pull/51298#discussion_r2341897347
##########
sql/core/src/test/resources/sql-tests/results/thetasketch.sql.out:
##########
@@ -0,0 +1,1208 @@
+-- Automatically generated by SQLQueryTestSuite
+-- !query
+DROP TABLE IF EXISTS t_int_1_5_through_7_11
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+CREATE TABLE t_int_1_5_through_7_11 AS
+VALUES
+ (1, 5), (2, 6), (3, 7), (4, 8), (5, 9), (6, 10), (7, 11) AS tab(col1, col2)
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+DROP TABLE IF EXISTS t_long_1_5_through_7_11
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+CREATE TABLE t_long_1_5_through_7_11 AS
+VALUES
+ (1L, 5L), (2L, 6L), (3L, 7L), (4L, 8L), (5L, 9L), (6L, 10L), (7L, 11L) AS
tab(col1, col2)
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+DROP TABLE IF EXISTS t_double_1_1_1_4_through_1_5_1_8
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+CREATE TABLE t_double_1_1_1_4_through_1_5_1_8 AS
+SELECT CAST(col1 AS DOUBLE) AS col1, CAST(col2 AS DOUBLE) AS col2
+FROM VALUES
+ (1.1, 1.4), (1.2, 1.5), (1.3, 1.6), (1.4, 1.7), (1.5, 1.8) AS tab(col1, col2)
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+DROP TABLE IF EXISTS t_float_1_1_1_4_through_1_5_1_8
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+CREATE TABLE t_float_1_1_1_4_through_1_5_1_8 AS
+SELECT CAST(col1 AS FLOAT) col1, CAST(col2 AS FLOAT) col2
+FROM VALUES
+ (1.1, 1.4), (1.2, 1.5), (1.3, 1.6), (1.4, 1.7), (1.5, 1.8) AS tab(col1, col2)
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+DROP TABLE IF EXISTS t_string_a_d_through_e_h
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+CREATE TABLE t_string_a_d_through_e_h AS
+VALUES
+ ('a', 'd'), ('b', 'e'), ('c', 'f'), ('d', 'g'), ('e', 'h') AS tab(col1, col2)
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+DROP TABLE IF EXISTS t_binary_a_b_through_e_f
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+CREATE TABLE t_binary_a_b_through_e_f AS
+VALUES
+ (X'A', X'B'), (X'B', X'C'), (X'C', X'D'), (X'D', X'E'), (X'E', X'F') AS
tab(col1, col2)
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+DROP TABLE IF EXISTS t_array_int_1_3_through_4_6
+-- !query schema
+struct<>
+-- !query output
+
+
+
+-- !query
+CREATE TABLE t_array_int_1_3_through_4_6 AS
+VALUES
+ (ARRAY(1), ARRAY(3)),
+ (ARRAY(2), ARRAY(4)),
+ (ARRAY(3), ARRAY(5)),
+ (ARRAY(4), ARRAY(6)) AS tab(col1, col2)
+-- !query schema
+struct<>
+-- !query output
Review Comment:
We also need tests with empty strings and Unicode characters.
I was digging into the past two days. I plan to propose specific tests in
this direction if you do not mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
