cloud-fan commented on code in PR #52256:
URL: https://github.com/apache/spark/pull/52256#discussion_r2342951455
##########
common/utils/src/main/scala/org/apache/spark/ErrorClassesJSONReader.scala:
##########
@@ -143,39 +165,81 @@ private object ErrorClassesJsonReader {
/**
* Information associated with an error class.
*
- * @param sqlState SQLSTATE associated with this class.
- * @param subClass SubClass associated with this class.
- * @param message Message format with optional placeholders (e.g.
<parm>).
- * The error message is constructed by concatenating the lines
with newlines.
+ * @param sqlState
+ * SQLSTATE associated with this class.
+ * @param subClass
+ * SubClass associated with this class.
+ * @param message
+ * Message format with optional placeholders (e.g. <parm>). The error
message is
+ * constructed by concatenating the lines with newlines.
+ * @param breakingChangeInfo
+ * Additional metadata if the error is due to a breaking change.
*/
private case class ErrorInfo(
message: Seq[String],
subClass: Option[Map[String, ErrorSubInfo]],
- sqlState: Option[String]) {
+ sqlState: Option[String],
+ breakingChangeInfo: Option[BreakingChangeInfo] = None) {
// For compatibility with multi-line error messages
@JsonIgnore
- val messageTemplate: String = message.mkString("\n")
+ val messageTemplate: String = message.mkString("\n") +
Review Comment:
nit: shall we add an `\n` between the main error message and the breaking
change message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
