Pajaraja commented on code in PR #51847:
URL: https://github.com/apache/spark/pull/51847#discussion_r2344511131
##########
sql/core/src/test/scala/org/apache/spark/sql/ParametersSuite.scala:
##########
@@ -786,6 +786,7 @@ class ParametersSuite extends QueryTest with
SharedSparkSession {
}
test("SPARK-50892: parameterized identifier inside a recursive CTE") {
+ spark.conf.set("spark.sql.cteRecursionRowLimit", "50")
Review Comment:
This was leftover from my testing. Removed it now.
##########
sql/core/src/test/resources/sql-tests/inputs/cte-recursion.sql:
##########
@@ -97,6 +97,37 @@ SELECT * FROM t LIMIT 60;
DROP VIEW ZeroAndOne;
+-- limited recursion allowed to stop from failing by putting LIMIT ALL
+WITH RECURSIVE t(n) MAX RECURSION LEVEL 100 AS (
Review Comment:
These are independent. MAX RECURSION LEVEL refers to the number of
iterations we do in the recursion, while LIMIT ALL overrides the number of rows
returned. LIMIT ALL should not override MAX RECURSION LEVEL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
