Github user animeshbaranawal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6633#discussion_r31894798
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala ---
    @@ -76,6 +76,24 @@ abstract class DataType {
         DataType.equalsIgnoreNullability(this, other)
     
       /**
    +   * Check if `this` is a primitive data type.
    +   */
    +  def isPrimitive: Boolean = {
    --- End diff --
    
    Can't we directly check whether the data type is ArrayType using 
datatype.isInstanceOf [ArrayType] or wouldn't it be better to directly check if 
the data cell is of type Sequence using .isInstanceOf [ Seq[ _ ] ] ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to