uros-db commented on code in PR #51824: URL: https://github.com/apache/spark/pull/51824#discussion_r2348721122
########## sql/core/src/test/resources/sql-tests/results/datetime-legacy.sql.out: ########## @@ -1676,6 +1676,106 @@ org.apache.spark.sql.catalyst.ExtendedAnalysisException } +-- !query +SELECT try_make_timestamp(make_date(2021, 07, 11)) Review Comment: These legacy test outputs are auto-generated based on imports of new test cases from `timestamp.sql`, I didn't add anything else for this particular purpose. I understand that golden file outputs are relatively large, but I did try to minimize the impact here - only kept the bare minimum essential test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
