srielau commented on code in PR #52173:
URL: https://github.com/apache/spark/pull/52173#discussion_r2338963415
##########
sql/core/src/main/scala/org/apache/spark/sql/classic/SparkSession.scala:
##########
@@ -509,6 +509,45 @@ class SparkSession private(
sql(sqlText, args.asScala.toMap)
}
+ /**
+ * Executes a SQL query substituting parameters by the given arguments with
optional names,
+ * returning the result as a `DataFrame`. This method allows the inner query
to determine
+ * whether to use positional or named parameters based on its parameter
markers.
+ */
+ private[sql] def sql(sqlText: String, args: Array[_], paramNames:
Array[String]): DataFrame = {
Review Comment:
Yes, so far I'm included to: Not
##########
sql/core/src/main/scala/org/apache/spark/sql/classic/SparkSession.scala:
##########
@@ -509,6 +509,45 @@ class SparkSession private(
sql(sqlText, args.asScala.toMap)
}
+ /**
+ * Executes a SQL query substituting parameters by the given arguments with
optional names,
+ * returning the result as a `DataFrame`. This method allows the inner query
to determine
+ * whether to use positional or named parameters based on its parameter
markers.
+ */
+ private[sql] def sql(sqlText: String, args: Array[_], paramNames:
Array[String]): DataFrame = {
Review Comment:
Yes, so far I'm inclined to: Not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
