sryza commented on code in PR #52154:
URL: https://github.com/apache/spark/pull/52154#discussion_r2372833662
##########
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto:
##########
@@ -90,6 +92,27 @@ message PipelineCommand {
optional string format = 8;
}
+ // Metadata about why a query function failed to be executed successfully.
+ message QueryFunctionFailure {
+ oneof reason {
+ // The logical plan that the query function needed to eagerly analyze in
order to know
+ // the schema / isStreaming / etc of the plan it produced, but could not
because it has
+ // unresolved dependencies.
+ spark.connect.Relation unresolved_dependency_plan = 1;
+ }
+ }
+
+ // The result of executing a user-defined query function.
+ message QueryFunctionResult {
+ oneof flow_function_evaluation_result {
+ // If the query function executed successfully, the unresolved logical
plan produced by it.
+ spark.connect.Relation analyzed_plan = 1;
Review Comment:
It's won't be analyzed yet, right? It's an unresolved plan that will be
analyzed once it gets to the server? Also, I think we should use the word
"relation" instead of "plan" – I think this was my bad originally and Dongjoon
recently pointed out that relation was more accurage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
