cloud-fan commented on code in PR #52336:
URL: https://github.com/apache/spark/pull/52336#discussion_r2384431914
##########
sql/core/src/test/scala/org/apache/spark/sql/MapStatusEndToEndSuite.scala:
##########
@@ -39,26 +38,38 @@ class MapStatusEndToEndSuite extends SparkFunSuite with
SQLTestUtils {
}
test("Propagate checksum from executor to driver") {
- assert(spark.sparkContext.conf
- .get("spark.sql.shuffle.orderIndependentChecksum.enabled") == "true")
-
assert(spark.conf.get("spark.sql.shuffle.orderIndependentChecksum.enabled") ==
"true")
assert(spark.sparkContext.conf.get("spark.sql.leafNodeDefaultParallelism")
== "5")
assert(spark.conf.get("spark.sql.leafNodeDefaultParallelism") == "5")
assert(spark.sparkContext.conf.get("spark.sql.classic.shuffleDependency.fileCleanup.enabled")
== "false")
assert(spark.conf.get("spark.sql.classic.shuffleDependency.fileCleanup.enabled")
== "false")
- withTable("t") {
- spark.range(1000).repartition(10).write.mode("overwrite").
- saveAsTable("t")
- }
+ var shuffleId = 0
+ Seq(("true", "false"), ("false", "true"), ("true", "true")).foreach {
+ case (orderIndependentChecksumEnabled: String,
checksumMismatchFullRetryEnabled: String) =>
+ withSQLConf(
+ "spark.sql.shuffle.orderIndependentChecksum.enabled" ->
orderIndependentChecksumEnabled,
Review Comment:
nit: let's not hardcode it, we can reference them by `SQLConf.key_name`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
