peter-toth commented on code in PR #52474:
URL: https://github.com/apache/spark/pull/52474#discussion_r2384863292
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala:
##########
@@ -293,8 +293,16 @@ trait BinaryNode extends LogicalPlan with
BinaryLike[LogicalPlan]
trait OrderPreservingUnaryNode extends UnaryNode
with AliasAwareQueryOutputOrdering[LogicalPlan] {
- override protected def outputExpressions: Seq[NamedExpression] = child.output
- override protected def orderingExpressions: Seq[SortOrder] =
child.outputOrdering
+
+ override def outputExpressions: Seq[NamedExpression] = child match {
Review Comment:
Why do we need these changes? AFAIK `OrderPreservingUnaryNode` means that
the node doesn't change ordering. What would be the meaning of it after this
cahnge?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala:
##########
@@ -293,8 +293,16 @@ trait BinaryNode extends LogicalPlan with
BinaryLike[LogicalPlan]
trait OrderPreservingUnaryNode extends UnaryNode
with AliasAwareQueryOutputOrdering[LogicalPlan] {
- override protected def outputExpressions: Seq[NamedExpression] = child.output
- override protected def orderingExpressions: Seq[SortOrder] =
child.outputOrdering
+
+ override def outputExpressions: Seq[NamedExpression] = child match {
Review Comment:
Why do we need these changes? AFAIK `OrderPreservingUnaryNode` means that
the node doesn't change ordering. What would be the meaning of it after this
change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
