Github user BryanCutler commented on the pull request:
https://github.com/apache/spark/pull/6205#issuecomment-110039541
Thanks for the feedback @squito! I updated the code with fixes from your
comments. I wasn't too happy with the `addMessageIfTimeout` function - it
seemed a little too intrusive and confusing for what it was doing. I changed
it slightly to propose that `RpcTimeout` just offers a `PartialFunction` that
can be used in a `Future.recover` callback. I think this way is a little
cleaner, but let me know if you prefer the function to use `Futures`, as
before, and I can change it back.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
