sryza commented on code in PR #52553:
URL: https://github.com/apache/spark/pull/52553#discussion_r2416916275
##########
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto:
##########
@@ -99,6 +100,15 @@ message PipelineCommand {
string schema_string = 5;
}
}
+
+ // Metadata that's only applicable to external sinks.
+ message ExternalSinkDetails {
Review Comment:
Any particular reason we need "external" in the name? Why not just call them
"sink details"?
##########
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto:
##########
Review Comment:
This comment needs to change
##########
sql/connect/common/src/main/protobuf/spark/connect/pipelines.proto:
##########
Review Comment:
Sinks aren't datasets, so I think we should rename this to `DefineOutput`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
