aokolnychyi commented on code in PR #52595:
URL: https://github.com/apache/spark/pull/52595#discussion_r2427645464
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/BatchWrite.java:
##########
@@ -105,31 +103,11 @@ default void onDataWriterCommit(WriterCommitMessage
message) {}
* <p>
* @param messages a list of commit messages from successful data writers,
produced by
* {@link DataWriter#commit()}.
- * @param metrics a map of operation metrics collected from the query
producing write.
- * The keys will be prefixed by operation type, eg `merge`.
- * <p>
- * Currently supported metrics are:
- * <ul>
- * <li>Operation Type = `merge`
- * <ul>
- * <li>`numTargetRowsCopied`: number of target rows
copied unmodified because
- * they did not match any action</li>
- * <li>`numTargetRowsDeleted`: number of target rows
deleted</li>
- * <li>`numTargetRowsUpdated`: number of target rows
updated</li>
- * <li>`numTargetRowsInserted`: number of target rows
inserted</li>
- * <li>`numTargetRowsMatchedUpdated`: number of target
rows updated by a
- * matched clause</li>
- * <li>`numTargetRowsMatchedDeleted`: number of target
rows deleted by a
- * matched clause</li>
- * <li>`numTargetRowsNotMatchedBySourceUpdated`: number
of target rows
- * updated by a not matched by source clause</li>
- * <li>`numTargetRowsNotMatchedBySourceDeleted`: number
of target rows
- * deleted by a not matched by source clause</li>
- * </ul>
- * </li>
- * </ul>
+ * @param operationMetrics operation metrics collected from the query
producing write.
Review Comment:
Are we missing an empty space here? Can we also mention that it is best
effort to collect/compute these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
