allisonwang-db commented on code in PR #52467:
URL: https://github.com/apache/spark/pull/52467#discussion_r2433656755


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3724,6 +3724,19 @@ object SQLConf {
       .booleanConf
       .createWithDefault(false)
 
+  val PYSPARK_BINARY_AS_BYTES =
+    buildConf("spark.sql.execution.pyspark.binaryAsBytes")
+      .doc("When true, BinaryType is mapped consistently to bytes in PySpark." 
+

Review Comment:
   "Mapped" here means the function input will be mapped as bytes right? 



##########
python/pyspark/sql/tests/test_udtf.py:
##########
@@ -3044,6 +3044,19 @@ def eval(self, v1, v2, v3, v4):
         for idx, field in enumerate(result_df.schema.fields):
             self.assertEqual(field.dataType, expected_output_types[idx])
 
+    def test_udtf_binary_type(self):

Review Comment:
   Can we also add one more test for test_arrow_udtf? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to