srielau commented on code in PR #52334:
URL: https://github.com/apache/spark/pull/52334#discussion_r2436211687


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/QueryPlanSuite.scala:
##########
@@ -37,7 +37,11 @@ class QueryPlanSuite extends SparkFunSuite {
     CurrentOrigin.reset()
 
     val mappedQuery = query mapExpressions {
-      case _: Expression => Literal(1)
+      case _: Expression =>
+        // Reset CurrentOrigin to prevent contamination from previous 
operations

Review Comment:
   I have been battling this one for a week. In fact the contamination came in 
from ANOTHER SUITE!
   And I was NOT able to repro locally. 
   Let me try again what happens when I remove this. Maybe the recent rework 
has fixed it.
   I think part of teh problem is tyhat these APIs are too low level.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to