azsefi opened a new pull request, #52649:
URL: https://github.com/apache/spark/pull/52649
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Stage level metrics like shuffle record counts, memory/disk spill bytes
etc., are enabled to be exposed by the prometheus servlet.
### Why are the changes needed?
The metrics listed in the
[documentation](https://spark.apache.org/docs/latest/monitoring.html#executor-task-metrics),
but not exposed in the prometheus API. The missing metrics are quite critical
for building monitoring dashboards.
### Does this PR introduce _any_ user-facing change?
New metrics have been added to the prometheus API.
```
metrics_executor_memoryBytesSpilled_bytes_total{application_id="local-1760714421896",
application_name="Spark shell", executor_id="driver"} 0
metrics_executor_diskBytesSpilled_bytes_total{application_id="local-1760714421896",
application_name="Spark shell", executor_id="driver"} 0
metrics_executor_shuffleWriteRecords_total{application_id="local-1760714421896",
application_name="Spark shell", executor_id="driver"} 28
metrics_executor_shuffleReadRecords_total{application_id="local-1760714421896",
application_name="Spark shell", executor_id="driver"} 28
metrics_executor_inputRecords_total{application_id="local-1760714421896",
application_name="Spark shell", executor_id="driver"} 100100
metrics_executor_outputBytes_bytes_total{application_id="local-1760714421896",
application_name="Spark shell", executor_id="driver"} 0
metrics_executor_outputRecords_total{application_id="local-1760714421896",
application_name="Spark shell", executor_id="driver"} 0
```
### How was this patch tested?
Run the change in local mode on laptop, and in cluster mode on kubernetes,
and checked the metrics API against the numbers show in the spark UI.
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
