viirya commented on code in PR #382:
URL:
https://github.com/apache/spark-kubernetes-operator/pull/382#discussion_r2421688373
##########
spark-submission-worker/src/main/java/org/apache/spark/k8s/operator/SparkAppSubmissionWorker.java:
##########
@@ -139,6 +139,12 @@ protected SparkAppDriverConf buildDriverConf(
if (StringUtils.isNotEmpty(applicationSpec.getJars())) {
primaryResource = new
JavaMainAppResource(Option.apply(applicationSpec.getJars()));
effectiveSparkConf.setIfMissing("spark.jars", applicationSpec.getJars());
+ } else if
("org.apache.spark.deploy.PythonRunner".equals(applicationSpec.getMainClass()))
{
Review Comment:
I wonder why in the branch below, it doesn't check if the main class is
`PythonRunner` before creating `PythonMainAppResource`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
