hvanhovell commented on code in PR #52610:
URL: https://github.com/apache/spark/pull/52610#discussion_r2429759767
##########
sql/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectAddArtifactsHandler.scala:
##########
@@ -141,7 +141,27 @@ class SparkConnectAddArtifactsHandler(val
responseObserver: StreamObserver[AddAr
summaries
}
- protected def cleanUpStagedArtifacts(): Unit =
Utils.deleteRecursively(stagingDir.toFile)
+ protected def cleanUpStagedArtifacts(): Unit = {
+ // Close all staged artifacts to release file handles and stream resources
+ stagedArtifacts.foreach { artifact =>
Review Comment:
Use `SparkErrorUtils.closeQuietly(...)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
