pan3793 commented on code in PR #52619: URL: https://github.com/apache/spark/pull/52619#discussion_r2435202825
########## sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/NonRegisteringSparkConnectDriver.scala: ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connect.client.jdbc + +import java.sql.{Connection, Driver, DriverPropertyInfo, SQLFeatureNotSupportedException} +import java.util.Properties +import java.util.logging.Logger + +import org.apache.spark.SparkBuildInfo.{spark_version => SPARK_VERSION} +import org.apache.spark.util.VersionUtils + +class NonRegisteringSparkConnectDriver extends Driver { Review Comment: @LuciferYang I would prefer to only write the public API in Java, similar to what we did for DSv2. Let me share my thoughts: 1. the proposed implementation is based on the existing `connect-client-jvm`, which is written in Scala, that means users must have scala-runtime on the classpath to use this JDBC driver eventually. 2. I agree we should define the public API in Java Interface or Class. In this case, the public JDBC APIs(e.g. `java.sql.Connection`, `Statement`, `ResultSet`, etc.) are defined in JDK, and I would not treat the concrete implementation classes as the public API, so it does not matter to write it in Java or Scala. 3. I can imagine a few sets of additional public APIs exposed by this JDBC driver, e.g. `VariantVal`, `CalendarInterval`, that will be returned by `Object getObject(int columnIndex)`, those classes are written in Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
