viirya commented on code in PR #52428:
URL: https://github.com/apache/spark/pull/52428#discussion_r2376394555
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -1042,10 +1052,13 @@ functionTableArgument
| functionArgument
;
+// This is only used in relationPrimary where having watermarkClause makes
sense. If this becomes
+// referred by other clause, please check wheter watermarkClause makes sense
to the clause.
+// If not, consider separate this rule.
functionTable
: funcName=functionName LEFT_PAREN
(functionTableArgument (COMMA functionTableArgument)*)?
- RIGHT_PAREN tableAlias
+ RIGHT_PAREN watermarkClause? tableAlias
Review Comment:
From the doc
https://docs.databricks.com/aws/en/sql/language-manual/sql-ref-syntax-qry-select-watermark,
it looks like `table_valued_function` has no `watermark_clause` support, but
we want to have it here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
