cloud-fan commented on code in PR #52334: URL: https://github.com/apache/spark/pull/52334#discussion_r2426063832
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/SubstituteParamsParser.scala: ########## @@ -0,0 +1,213 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.catalyst.parser + +import org.antlr.v4.runtime.{CharStreams, CommonTokenStream} + +import org.apache.spark.internal.Logging +import org.apache.spark.sql.AnalysisException +import org.apache.spark.sql.catalyst.trees.SQLQueryContext +import org.apache.spark.sql.internal.SQLConf + + +/** + * A parameter substitution parser that replaces parameter markers in SQL text with their values. + * This parser finds parameter markers and substitutes them with provided values to produce + * a modified SQL string ready for execution. + */ +class SubstituteParamsParser extends Logging { + + /** + * Substitute parameter markers in SQL text with provided values. + * Always uses compoundOrSingleStatement parsing which can handle all SQL constructs. + * + * @param sqlText The original SQL text containing parameter markers + * @param namedParams Map of named parameter values (paramName -> value) + * @param positionalParams List of positional parameter values in order + * @return A tuple of (modified SQL string with parameters substituted, + * number of consumed positional parameters) + */ + def substitute( + sqlText: String, + namedParams: Map[String, String] = Map.empty, + positionalParams: List[String] = List.empty): (String, Int, PositionMapper) = { + + // Quick pre-check: if there are no parameter markers in the text, skip parsing entirely + if (!sqlText.contains("?") && !sqlText.contains(":")) { + return (sqlText, 0, PositionMapper.identity(sqlText)) + } + + val lexer = new SqlBaseLexer(new UpperCaseCharStream(CharStreams.fromString(sqlText))) + lexer.removeErrorListeners() + lexer.addErrorListener(ParseErrorListener) + + val tokenStream = new CommonTokenStream(lexer) + val parser = new SqlBaseParser(tokenStream) + + // Use shared parser configuration to ensure consistency with main parser. + AbstractParser.configureParser(parser, sqlText, tokenStream, SQLConf.get) + + val astBuilder = new SubstituteParmsAstBuilder() + + // Use shared two-stage parsing strategy for consistent error handling. + val ctx = AbstractParser.executeWithTwoStageStrategy(parser, tokenStream, + _.compoundOrSingleStatement()) + val parameterLocations = astBuilder.extractParameterLocations(ctx) + + // Substitute parameters in the original text. + val (substitutedSql, appliedSubstitutions) = substituteAtLocations(sqlText, parameterLocations, + namedParams, positionalParams) + val consumedPositionalParams = parameterLocations.positionalParameterLocations.length + + // Create position mapper for error context translation. + val positionMapper = PositionMapper(sqlText, substitutedSql, appliedSubstitutions) + + (substitutedSql, consumedPositionalParams, positionMapper) + } + + /** + * Detects parameter markers in SQL text without performing substitution. + * Always uses compoundOrSingleStatement parsing which can handle all SQL constructs. + * + * @param sqlText The original SQL text to analyze + * @return A tuple of (hasPositionalParameters, hasNamedParameters) + */ + def detectParameters(sqlText: String): (Boolean, Boolean) = { Review Comment: This detection means a repeated parsing. Why can't we have a global state in `SubstituteParmsAstBuilder`, and detect mixed parameter markers during real parsing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
