Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6671#discussion_r31938687
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
    @@ -460,7 +460,9 @@ private[deploy] class SparkSubmitArguments(args: 
Seq[String], env: Map[String, S
             |                              on one of the worker machines 
inside the cluster ("cluster")
             |                              (Default: client).
             |  --class CLASS_NAME          Your application's main class (for 
Java / Scala apps).
    -        |  --name NAME                 A name of your application.
    +        |  --name NAME                 A name of your application. In 
yarn-cluster mode the name
    --- End diff --
    
    I'm not a big fan of mentioning YARN here since this parameter if for all 
modes. Also, I don't think the documentation should encourage the use of 
`SparkContext.setAppName`, exactly because it has different behaviour in client 
and cluster modes.
    
    In summary, I think this comment should be left alone. If `--name` for some 
reason doesn't work in yarn-client mode, that should be fixed. If there are 
other documents that talk about `SparkContext.setAppName`, they should probably 
be changed too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to