pan3793 commented on PR #52641: URL: https://github.com/apache/spark/pull/52641#issuecomment-3417793863
@dongjoon-hyun I understand sometimes having `-SNAPSHOT` introduces noise for the dev process, e.g., golden files, but this is easy to tackle, for example, by redacting or using variables like `SparkBuildInfo.spark_version()` instead of a string literal, for assertions. As you can see, all tests now pass with just 2 line changes in the test code. > In addition, if we only consider the official Spark release, why do we need this PR? My point is, we should use the official Spark release to justify whether it's a breaking change or not, in the meantime, we should make the code friendly for vendor distributions. I also checked the CDH Hive, `version()` returns full version, which is much intuitive. ``` hive> SELECT version() 2.1.1-cdh6.3.2 b3393cf499504df1d2a12d34b4285e5d0c02be11 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
