ksbeyer commented on code in PR #52016:
URL: https://github.com/apache/spark/pull/52016#discussion_r2395217281
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala:
##########
@@ -438,28 +377,21 @@ object TableOutputResolver extends SQLConfHelper with
Logging {
expectedType: StructType,
byName: Boolean,
conf: SQLConf,
- addError: String => Unit,
- colPath: Seq[String]): Option[NamedExpression] = {
- val nullCheckedInput = checkNullability(input, expected, conf, colPath)
+ colPath: Seq[String]): Expression = {
+ val nullCheckedInput = withNullabilityChecked(input, expected, conf,
colPath)
val fields = inputType.zipWithIndex.map { case (f, i) =>
+ // todo: this blows up input evaluation by each field!
Review Comment:
- [ ] can we use a cast? can we use a WithExpr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
