Yicong-Huang commented on code in PR #52537:
URL: https://github.com/apache/spark/pull/52537#discussion_r2417550698
##########
sql/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/ColumnTestSuite.scala:
##########
@@ -209,4 +209,51 @@ class ColumnTestSuite extends ConnectFunSuite {
testColName(structType1, _.struct(structType1))
import org.apache.spark.util.ArrayImplicits._
testColName(structType2, _.struct(structType2.fields.toImmutableArraySeq:
_*))
+
+ test("transform with named function") {
+ val a = fn.col("a")
+ def addOne(c: Column): Column = c + 1
+ val transformed = a.transform(addOne)
+ assert(transformed == (a + 1))
+ }
+
+ test("transform with lambda") {
+ val a = fn.col("a")
+ val transformed = a.transform(c => c * 2)
+ assert(transformed == (a * 2))
+ }
+
+ test("transform chaining") {
+ val a = fn.col("a")
+ val transformed = a.transform(c => c + 1).transform(c => c * 2)
+ assert(transformed == ((a + 1) * 2))
+ }
+
+ test("transform with complex lambda") {
+ val a = fn.col("a")
+ val transformed = a.transform(c => fn.when(c > 10, c * 2).otherwise(c))
+ val expected = fn.when(a > 10, a * 2).otherwise(a)
+ assert(transformed == expected)
+ }
+
+ test("transform with built-in functions") {
+ val a = fn.col("a")
+ val transformed = a.transform(fn.trim).transform(fn.upper)
+ val expected = fn.upper(fn.trim(a))
+ assert(transformed == expected)
+ }
+
+ test("transform with arithmetic operations") {
+ val a = fn.col("a")
+ val transformed = a.transform(_ + 10).transform(_ * 2).transform(_ - 5)
+ assert(transformed == (((a + 10) * 2) - 5))
+ }
+
+ test("transform mixing named functions and lambdas") {
+ val a = fn.col("a")
+ def triple(c: Column): Column = c * 3
+ val transformed = a.transform(triple).transform(c => c + 10)
+ assert(transformed == ((a * 3) + 10))
+ }
+
Review Comment:
added!
##########
sql/core/src/test/scala/org/apache/spark/sql/ColumnExpressionSuite.scala:
##########
@@ -3144,4 +3144,22 @@ class ColumnExpressionSuite extends QueryTest with
SharedSparkSession {
checkAnswer(df.select($"dd" / ($"num" + 3)),
Seq((Duration.ofDays(2))).toDF())
}
+
+ test("Column.transform") {
+ val df = Seq(" hello ", " world ").toDF("text")
+
+ checkAnswer(
+ df.select($"text".transform(trim).transform(upper)),
+ Seq("HELLO", "WORLD").toDF()
+ )
+ }
+
+ test("Column.transform: chaining") {
Review Comment:
changed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
