cloud-fan commented on PR #52584: URL: https://github.com/apache/spark/pull/52584#issuecomment-3407716019
what happens if we don't modify `FileFormatWriter.scala` at all? I think it only affects non-planned-write and planned-write with concurrent write, and we can improve them later. (ideally the sort should be handled at the logical plan phase) I think the only issue is for test: `if (Utils.isTesting) outputOrderingMatched = orderingMatched`. We can fix the affected tests and specify the required ordering explicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
