pan3793 commented on PR #52436:
URL: https://github.com/apache/spark/pull/52436#issuecomment-3331396204

   @dongjoon-hyun the test suite hierarchy is
   
   ```
   trait V1WriteCommandSuiteBase ...
   class V1WriteCommandSuite extends V1WriteCommandSuiteBase ...
   class V1WriteHiveCommandSuite extends V1WriteCommandSuiteBase ...
   ```
   
   `V1WriteHiveCommandSuite` intends to have only Hive SerDe table cases, so 
`spark.sql.legacy.createHiveTableByDefault=false` is necessary.
   
   `spark.sql.legacy.createHiveTableByDefault=true` indirectly takes the same 
effect as `STORED AS PARQUET` here, but I prefer to use the latter instead of 
the indirect approach. BTW, in `V1WriteCommandSuite`, it explicitly uses `USING 
PARQUET` in the `CREATE TABLE` clause.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to