Github user squito commented on the pull request:
https://github.com/apache/spark/pull/6648#issuecomment-110109731
I feel pretty good about this patch now. I think the additional unit tests
are pretty solid, and this passes the longer fault-tolerance tests I have.
(With the other `DAGScheduler` changes I have, it passes with even tighter
conditions as well.) There are a few "code style" issues I'd like feedback on:
* is there a better way to do the
`spark.shuffle.unsafe.testing.allowSpillMove` setting I put in to test out the
different code paths in `UnsafeShuffle`?
* is there a good home for the long fault-tolerance test?
* is there a better way to test that all attempts get cleaned up, than how
I exposed `getShuffleFiles` and use it in
[`ShuffleSuite`](https://github.com/squito/spark/blob/64ead29183142bec88c285032edaf7ddbf55c76a/core/src/test/scala/org/apache/spark/shuffle/ShuffleSuite.scala#L373)?
I think what I have is decent, but still I am hoping somebody else might have
a better suggestion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
