dongjoon-hyun commented on code in PR #52552:
URL: https://github.com/apache/spark/pull/52552#discussion_r2427655105
##########
common/network-common/src/test/java/org/apache/spark/network/client/TransportClientFactorySuite.java:
##########
@@ -225,11 +225,12 @@ public void closeFactoryBeforeCreateClient() {
}
@Test
- public void fastFailConnectionInTimeWindow() {
+ public void fastFailConnectionInTimeWindow() throws IOException,
InterruptedException {
TransportClientFactory factory = context.createClientFactory();
TransportServer server = context.createServer();
int unreachablePort = server.getPort();
server.close();
+ Thread.sleep(1000);
Review Comment:
Ya, it's a slight change and could be configurable via some Netty confs.
Since we only use this `close-and-reopen` pattern to get an unreachable port
number in our test cases, I didn't dig the further.
Thank you, @LuciferYang . If you hit any issue, let me know. I hope we can
test this via Apache Spark 4.1.0-preview3 widely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
