Ngone51 commented on code in PR #52606:
URL: https://github.com/apache/spark/pull/52606#discussion_r2427912834
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/QueryExecutionSuite.scala:
##########
@@ -320,11 +321,15 @@ class QueryExecutionSuite extends SharedSparkSession {
private def cleanupShuffles(): Unit = {
val blockManager = spark.sparkContext.env.blockManager
+ val mapOutputTrackerMaster =
+
spark.sparkContext.env.mapOutputTracker.asInstanceOf[MapOutputTrackerMaster]
blockManager.diskBlockManager.getAllBlocks().foreach {
case ShuffleIndexBlockId(shuffleId, _, _) =>
spark.sparkContext.shuffleDriverComponents.removeShuffle(shuffleId,
true)
case _ =>
}
+ // Shuffle cleanup should not clean up shuffle metadata on the driver
+ assert(mapOutputTrackerMaster.shuffleStatuses.nonEmpty)
Review Comment:
Tests fails this assert before the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
