yhuang-db commented on code in PR #51505:
URL: https://github.com/apache/spark/pull/51505#discussion_r2427275479
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproxTopKAggregates.scala:
##########
@@ -318,7 +325,72 @@ object ApproxTopK {
StructType(
StructField("sketch", BinaryType, nullable = false) ::
StructField("itemDataType", itemDataType) ::
- StructField("maxItemsTracked", IntegerType, nullable = false) :: Nil)
+ StructField("maxItemsTracked", IntegerType, nullable = false) ::
+ StructField("typeCode", BinaryType, nullable = false) :: Nil)
Review Comment:
Need an explicit encoding of the dataType, because the `null` of
`StructField("itemDataType", itemDataType)` might be implicitly widen during
union.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
