cloud-fan commented on code in PR #52334:
URL: https://github.com/apache/spark/pull/52334#discussion_r2429590259
##########
sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/DataTypeAstBuilder.scala:
##########
@@ -45,18 +45,39 @@ class DataTypeAstBuilder extends
SqlBaseParserBaseVisitor[AnyRef] {
withOrigin(ctx)(StructType(visitColTypeList(ctx.colTypeList)))
}
- override def visitStringLit(ctx: StringLitContext): Token = {
- if (ctx != null) {
- if (ctx.STRING_LITERAL != null) {
- ctx.STRING_LITERAL.getSymbol
- } else {
- ctx.DOUBLEQUOTED_STRING.getSymbol
- }
- } else {
- null
- }
+ override def visitStringLiteralValue(ctx: StringLiteralValueContext): Token =
+ Option(ctx).map(_.STRING_LITERAL.getSymbol).orNull
+
+ override def visitDoubleQuotedStringLiteralValue(
+ ctx: DoubleQuotedStringLiteralValueContext): Token =
+ Option(ctx).map(_.DOUBLEQUOTED_STRING.getSymbol).orNull
+
+ override def visitIntegerVal(ctx: IntegerValContext): Token =
+ Option(ctx).map(_.INTEGER_VALUE.getSymbol).orNull
+
+ override def visitStringLiteralInContext(ctx:
StringLiteralInContextContext): Token = {
+ visit(ctx.stringLitWithoutMarker).asInstanceOf[Token]
+ }
+
+ override def visitNamedParameterMarkerRule(ctx:
NamedParameterMarkerRuleContext): Token = {
+ // This should be unreachable due to grammar-level blocking of parameter
markers
+ // when legacy parameter substitution is enabled
+ QueryParsingErrors.unexpectedUseOfParameterMarker(ctx)
+ }
+
+ override def visitPositionalParameterMarkerRule(
Review Comment:
shall we override `visitNamedParameterLiteral`/`visitPosParameterLiteral`
here too and fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
