pan3793 commented on PR #52665: URL: https://github.com/apache/spark/pull/52665#issuecomment-3421973178
@sarutak I think we should take them one by one. [AppStatusListenerSuite.scala](https://github.com/apache/spark/blob/2bb73fbdeb19f0a972786d3ea33d3263bf84ab66/core/src/test/scala/org/apache/spark/status/AppStatusListenerSuite.scala#L76) you mentioned is actually affecting display in Spark UI, changing this may surprise users, I lean towards not touching it, but can do if someone thinks we should. In `SparkBuild.scala`, I think the Spark devs already noticed that, that's why the parent dir of `java.home` is used, see https://github.com/apache/spark/pull/5441 ``` .orElse(sys.props.get("java.home").map { p => new File(p).getParentFile().getAbsolutePath() }) ``` it's correct for JDK 8 and prior. I think we should change it to ``` .orElse(sys.props.get("java.home")) ``` for Spark 4.0 and master, since it's not sure for JDK 17+ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
