zhengruifeng commented on code in PR #52648:
URL: https://github.com/apache/spark/pull/52648#discussion_r2450022201
##########
python/pyspark/sql/connect/functions/builtin.py:
##########
@@ -3945,23 +3945,99 @@ def make_time(hour: "ColumnOrName", minute:
"ColumnOrName", second: "ColumnOrNam
make_time.__doc__ = pysparkfuncs.make_time.__doc__
+@overload
def make_timestamp(
years: "ColumnOrName",
months: "ColumnOrName",
days: "ColumnOrName",
hours: "ColumnOrName",
mins: "ColumnOrName",
secs: "ColumnOrName",
+) -> Column:
+ ...
+
+
+@overload
+def make_timestamp(
+ years: "ColumnOrName",
+ months: "ColumnOrName",
+ days: "ColumnOrName",
+ hours: "ColumnOrName",
+ mins: "ColumnOrName",
+ secs: "ColumnOrName",
+ timezone: "ColumnOrName",
+) -> Column:
+ ...
+
+
+@overload
+def make_timestamp(*, date: "ColumnOrName", time: "ColumnOrName") -> Column:
+ ...
+
+
+@overload
+def make_timestamp(
+ *, date: "ColumnOrName", time: "ColumnOrName", timezone: "ColumnOrName"
+) -> Column:
+ ...
+
+
+def make_timestamp(
+ years: Optional["ColumnOrName"] = None,
+ months: Optional["ColumnOrName"] = None,
+ days: Optional["ColumnOrName"] = None,
+ hours: Optional["ColumnOrName"] = None,
+ mins: Optional["ColumnOrName"] = None,
+ secs: Optional["ColumnOrName"] = None,
timezone: Optional["ColumnOrName"] = None,
+ *,
Review Comment:
we removed `*` in similar functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
