anishshri-db commented on code in PR #52642:
URL: https://github.com/apache/spark/pull/52642#discussion_r2450423029
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala:
##########
@@ -1045,6 +1046,70 @@ class AdaptiveQueryExecSuite
}
}
+ test("aqe in stateless streaming query") {
+ withSQLConf(
+ SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
+ SQLConf.ADAPTIVE_EXECUTION_FORCE_APPLY.key -> "true") {
+ withTempView("test") {
+ val input = MemoryStream[Int]
+ val stream = input.toDF().select(col("value"), (col("value") * 3) as
"three")
+
+ // join a table with a stream
+ val joined = spark.table("testData").join(stream,
Seq("value")).where("three > 40")
+ val query =
joined.writeStream.format("memory").queryName("test").start()
+ input.addData(1, 10, 20, 40, 50)
+ try {
+ query.processAllAvailable()
+ } finally {
+ query.stop()
+ }
+
+ // aqe should be enabled in a stateless streaming query
+ val plan = query.asInstanceOf[StreamingQueryWrapper]
+ .streamingQuery.lastExecution.executedPlan
+ val ret = plan.find {
+ case _: AdaptiveSparkPlanExec | _: QueryStageExec => true
+ case _ => false
+ }
+ assert(ret.nonEmpty,
+ s"expected AQE to take effect but can't find AQE node, plan: $plan")
+ // aqe config should still be enabled
+ assert(query.sparkSession.sessionState.conf.adaptiveExecutionEnabled)
+ }
+ }
+ }
+
+ test("no aqe in stateful streaming query") {
+ withSQLConf(
+ SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
+ SQLConf.ADAPTIVE_EXECUTION_FORCE_APPLY.key -> "true") {
+ withTempView("test") {
+ val input = MemoryStream[Int]
+ val stream = input.toDF().select(col("value"), (col("value") * 3) as
"three")
+
+ // apply aggregation
+ val agg = stream.groupBy("value").agg(sum("three"))
+ val query =
agg.writeStream.format("memory").queryName("test").outputMode("update").start()
+ input.addData(1, 2, 3, 4, 5)
+ try {
+ query.processAllAvailable()
+ } finally {
+ query.stop()
+ }
+
+ // aqe should not be enabled in a stateful streaming query
+ val plan = query.asInstanceOf[StreamingQueryWrapper]
+ .streamingQuery.lastExecution.executedPlan
+ val ret = plan.find {
+ case _: AdaptiveSparkPlanExec | _: QueryStageExec => true
+ case _ => false
+ }
+ assert(ret.isEmpty)
+ }
+ }
+ }
+
Review Comment:
nit: extra newline ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
