cloud-fan commented on code in PR #52443:
URL: https://github.com/apache/spark/pull/52443#discussion_r2450475777
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala:
##########
@@ -165,22 +165,30 @@ case class EnsureRequirements(
// Check if the following conditions are satisfied:
// 1. There are exactly two children (e.g., join). Note that Spark
doesn't support
// multi-way join at the moment, so this check should be sufficient.
- // 2. All children are of `KeyGroupedPartitioning`, and they are
compatible with each other
+ // 2. All children are of the compatible key group partitioning or
+ // compatible shuffle partition id pass through partitioning
Review Comment:
```suggestion
// 2. All children are of the compatible key group partitioning or
// compatible shuffle partition id pass through partitioning
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
