uros-db commented on code in PR #52629:
URL: https://github.com/apache/spark/pull/52629#discussion_r2450609955
##########
sql/core/src/test/scala/org/apache/spark/sql/types/GeographyTypeSuite.scala:
##########
@@ -216,4 +217,15 @@ class GeographyTypeSuite extends SparkFunSuite {
}
}
}
+
+ test("PhysicalDataType maps GeographyType to PhysicalGeographyType") {
Review Comment:
We could, but CRS/ALG based type construction is present only for JSON
parsing (which we have separate tests for). Here, it's more appropriate to test
types that can be made from the SQL parser for example - and those are
SRID-based construction, and of course the special string value "ANY". Hence, I
would keep this as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
