wankunde commented on PR #52678: URL: https://github.com/apache/spark/pull/52678#issuecomment-3431547277
> According to https://dev.java/learn/jvm/tool/garbage-collection/zgc-deepdive/ > > > ZGC has three different sizes for regions; small, medium, and large. > > Seems the waste is not as bad as G1, but this change still benefits ZGC memory utilization. > > Have you used Shenandoah GC? According to [#34846 (review)](https://github.com/apache/spark/pull/34846#pullrequestreview-883976574), I think we should apply the same change to Shenandoah GC. > > > The same behavior affects the Shenandoah GC as well since it reuses the G1 region-based heap structure. Hi, @pan3793 run the previous test with `-Xmx1000m` and different GCs, I think this optimization is also helpful for ZGC and xx. Test code: https://gist.githubusercontent.com/wankunde/b7cf073b31f3a4bf5b525ab4a6b1f700/raw/85db977f5ef8609db27ced49d10ace9a248433c1/TestBlockSize.java Test result: | | Max allocated size without optimization | Max allocated size with optimization | |--------------|-----------------------------------------|---------------------------------------| | G1GC | 817889280 | 1019211984 | | ZGC | 671088640 | 1006629120 | | ShenandoahGC | 855638016 | 964686240 | Detail test result: https://gist.github.com/wankunde/6f3b6ed8abaa247307469ab5a4fae2bb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
