dongjoon-hyun commented on code in PR #52689:
URL: https://github.com/apache/spark/pull/52689#discussion_r2456301812


##########
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala:
##########
@@ -395,12 +395,16 @@ private[spark] class PythonWorkerFactory(
     }
   }
 
+  private val workerLogCapture =
+    envVars.get("SPARK_SESSION_UUID").map(new PythonWorkerLogCapture(_))

Review Comment:
   SPARK_SESSION_UUID looks like too general name if this is supposed to be 
used for only PySpark environment. Do you think we can have `PYSPARK_` prefix 
like the other PySpark environment variables, @ueshin ?
   
   ```
   PYSPARK_PYTHON
   PYSPARK_DRIVER_PYTHON
   PYSPARK_ARCHIVES_PATH
   PYSPARK_EXECUTOR_MEMORY_MB
   PYSPARK_PLANNER_MEMORY_MB
   PYSPARK_SUBMIT_ARGS
   PYSPARK_PIN_THREAD
   PYSPARK_NO_NAMESPACE_SHARE
   PYSPARK_UDS_MODE
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to